On Tue, Jul 14, 2026 at 02:45:11PM +0500, Andrey Borodin wrote:
> To make iterating on a fix convenient, the attached patch turns the manual
> gdb recipe from the first message into a deterministic TAP test. It adds a
> "vacuum-before-toast" injection point in vacuum_rel().
>
> The test asserts the correct behavior (CREATE INDEX succeeds), so it fails
> on today's codebase.
Is there any difference in coverage with the tests posted at [1]? As
far as I can see, this is just a more complicated implementation of
the same thing. You are providing the same coverage for CREATE INDEX
and index builds, missing the other code paths with data copy.
I'd suggest to move the discussion entirely to the other thread, at
this stage, where the patch has been posted, even if I kind of agree
that the thread being marked as related only to REPACK can be
confusing.
The CF entry at [2] tracks both threads.
[1]: https://www.postgresql.org/message-id/flat/19519-fe02d8ff679d834d@postgresql.org
[2]: https://commitfest.postgresql.org/patch/6824/
--
Michael
