On Thu, Jul 09, 2026 at 11:49:24AM -0700, Bharath Rupireddy wrote:
> So I agree with using the _ext version for the ACL check when building the
> relations list for database-wide vacuum. It addresses the concurrent table
> drops issue. The v8 patch looks good to me.
>
> Also, I don't have a strong opinion on adding the Assert(missing_ok ||
> CheckRelationOidLockedByMe(relid, AccessShareLock, true)); because the
> is_missing flag in v8 already conveys whether the caller holds the relation
> lock or not: missing_ok = true means no lock held, missing_ok = false means
> the caller holds it.
Cool, I'll address everyone's feedback and get this committed in the next
few days.
--
nathan
