Re: [PATCH] Document wal_compression=on - Mailing list pgsql-hackers

From Christoph Berg
Subject Re: [PATCH] Document wal_compression=on
Date
Msg-id akJ-JMX235QusQx6@msg.df7cb.de
Whole thread
In response to Re: [PATCH] Document wal_compression=on  (John Naylor <johncnaylorls@gmail.com>)
Responses Re: [PATCH] Document wal_compression=on
List pgsql-hackers
Re: John Naylor
> +        The value <literal>on</literal> is a deprecated alias for
> <literal>pglz</literal>.
> 
> "deprecated" implies we may remove it someday. I don't think we'd gain
> from doing that, but we could instead call 'on' a "historical
> spelling" of 'pglz'.

Or perhaps leave the door open for picking a better default in the future?

     The value <literal>on</literal> is currently an alias for <literal>pglz</literal>.

(I would be fine with either of the 3 variants.)

Maybe we should also update the postgresql.conf.sample:

 #wal_compression = off                  # enables compression of full-page writes;
-                                        # off, pglz, lz4, zstd, or on
+                                        # off, pglz (or on), lz4, or zstd

(Or just delete it there.)

Christoph



pgsql-hackers by date:

Previous
From: Xuneng Zhou
Date:
Subject: Re: [PATCH] Prevent repeated deadlock-check signals in standby buffer pin waits
Next
From: Thom Brown
Date:
Subject: Re: Per-thread leak in ECPG's memory.c