Re: BUG #19519: REPACK can fail due to missing chunk for toast value - Mailing list pgsql-bugs

From Michael Paquier
Subject Re: BUG #19519: REPACK can fail due to missing chunk for toast value
Date
Msg-id ak806l8j5A45y2LD@paquier.xyz
Whole thread
In response to Re: BUG #19519: REPACK can fail due to missing chunk for toast value  (Konstantin Knizhnik <knizhnik@garret.ru>)
List pgsql-bugs
On Thu, Jul 09, 2026 at 08:17:06AM +0300, Konstantin Knizhnik wrote:
> Changing `table_relation_fetch_toast_slice` signature breaks compatibility
> with some extensions, for example duckdb.
> I wonder if we can change only  `bool (*relation_fetch_toast_slice)(...,
> bool missing_ok)` callback signature, but preserve signature of
> `table_relation_fetch_toast_slice`, adding one more function
> `table_relation_try_fetch_toast_slice`:

Thanks for the input.

Adding more functions implies to change the size of TableAmRoutine,
which may be bad.  For now I'd be tempted to just focus on how to fix
the problem on HEAD in a way we are happy with.  We could sort out an
optional back-branch version as a second step.
--
Michael

Attachment

pgsql-bugs by date:

Previous
From: Tom Lane
Date:
Subject: Re: BUG #19545: Integer truncation of `GinTuple.keylen` causes out-of-bounds read in parallel GIN index build
Next
From: Ewan Young
Date:
Subject: Re: BUG #19545: Integer truncation of `GinTuple.keylen` causes out-of-bounds read in parallel GIN index build