Re: Fix contradictory comment for pgstat_slru_flush_cb() - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Fix contradictory comment for pgstat_slru_flush_cb()
Date
Msg-id ajnFUAo0iGCcx63c@paquier.xyz
Whole thread
In response to Fix contradictory comment for pgstat_slru_flush_cb()  (Shinya Kato <shinya11.kato@gmail.com>)
List pgsql-hackers
On Mon, Jun 22, 2026 at 10:00:58PM +0900, Shinya Kato wrote:
> The first paragraph has the return value backwards. The function
> returns true only when nowait is set and the lock could not be
> acquired, and false otherwise, as the second paragraph correctly
> states. The reversed paragraph is a leftover from f4d3ca421d9, which
> removed an unrelated sentence but not the surrounding text.
>
> The attached patch removes the incorrect first paragraph.

Looks like you are right here.  Grabbed for later.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Christophe Pettus
Date:
Subject: Re: The PostgreSQL C Dialect
Next
From: Peter Smith
Date:
Subject: Re: Support EXCEPT for TABLES IN SCHEMA publications