Re: Fix \crosstabview to honor \pset display_true/display_false - Mailing list pgsql-hackers

From Álvaro Herrera
Subject Re: Fix \crosstabview to honor \pset display_true/display_false
Date
Msg-id ajV67urZ49oBBZvQ@alvherre.pgsql
Whole thread
In response to Re: Fix \crosstabview to honor \pset display_true/display_false  ("David G. Johnston" <david.g.johnston@gmail.com>)
Responses Re: Fix \crosstabview to honor \pset display_true/display_false
List pgsql-hackers
On 2026-Jun-19, David G. Johnston wrote:

> Looked a bit closer at printQuery this time; disliking that the if
> condition has an awareness of the implementation of
> printQueryOptDisplayValue since it lists !isnull and ftype != BOOLOID
> explicitly.
> 
> How about not touching print.c at all with this patch, moving the
> printQueryOptDisplayValue into crosstabview.c and leaving printQuery alone
> since it is already correct?

That was my reaction also, so I produced this POC patch.  I think
print.h needs some more work, and that'd be only for 20.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
"La libertad es como el dinero; el que no la sabe emplear la pierde" (Alvarez)

Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: fix pg_mkdir_p to tolerate concurrent directory creation
Next
From: Tom Lane
Date:
Subject: check_stack_depth() vs. tail-recursion optimization