Request a Demo
Home   >   mailing lists

Re: faulty error handling around pgstat_count_io_op_time() - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: faulty error handling around pgstat_count_io_op_time()
Date
Msg-id ajIzvYDlo9_X7w2_@paquier.xyz
Whole thread
List pgsql-hackers
Tree view 
On Wed, Jun 17, 2026 at 10:29:36AM +0530, Ayush Tiwari wrote:
> I agree on this change, but the original placement was also recording
> the I/O timing of the attempted write, not just byte count, so moving
> it post save_errno drops that. (But even the ordinary write/fsync
> paths ereport before reaching their pgstat_count_io_op_time() call).

FWIW, I don't understand why registering the time taken for a failure
would make sense for WAL segment inits.  :)
--
Michael
Attachment

pgsql-hackers by date:

Previous
From: jihyun bahn
Date:
Subject: Re: [PATCH] Fix replica identity mismatch for partitioned tables with publish_via_partition_root
Next
From: Bertrand Drouvot
Date:
Subject: Re: Avoid orphaned objects dependencies, take 3