Re: 004_timeline_switch TAP test may fail - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: 004_timeline_switch TAP test may fail
Date
Msg-id ajHcy2e-xuba6fVU@paquier.xyz
Whole thread
In response to Re: 004_timeline_switch TAP test may fail  (Ewan Young <kdbase.hack@gmail.com>)
List pgsql-hackers
On Tue, Jun 16, 2026 at 06:51:48PM +0800, Ewan Young wrote:
> One small thing: the rest of this file uses count(*), so I'd write count(*) = 2
> rather than count(1) = 2 just for local consistency. And the comment reads a
> little better as something like "Wait until both standbys have
> connected to the primary",
> since by this point they've already started -- what we're waiting for is the
> connection.

Both queries work the same for this purpose, so any of them is fine.
The comment needs to be refined a bit, though.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Masahiko Sawada
Date:
Subject: Re: [PATCH] Release replication slot on error in SQL-callable slot functions
Next
From: Bruce Momjian
Date:
Subject: Re: First draft of PG 19 release notes