Re: Fix --missing-stats-only false positive for partitioned expression indexes - Mailing list pgsql-hackers

From Nathan Bossart
Subject Re: Fix --missing-stats-only false positive for partitioned expression indexes
Date
Msg-id ajF2UpggfQ_WPJ95@nathan
Whole thread
In response to Fix --missing-stats-only false positive for partitioned expression indexes  (Baji Shaik <baji.pgdev@gmail.com>)
Responses Re: Fix --missing-stats-only false positive for partitioned expression indexes
Re: Fix --missing-stats-only false positive for partitioned expression indexes
List pgsql-hackers
On Tue, Jun 16, 2026 at 10:25:52AM -0500, Baji Shaik wrote:
> I tested "vacuumdb --missing-stats-only"  and found that it flags
> partitioned tables that have expression indexes, even after a full
> ANALYZE.

Thanks for reporting.

-                             " OR EXISTS (SELECT NULL FROM pg_catalog.pg_attribute a\n"
+                             " OR (NOT p.inherited"
+                             " AND EXISTS (SELECT NULL FROM pg_catalog.pg_attribute a\n"

I'm curious why you added this check to the beginning and surrounded the
rest with parentheses.  Wouldn't it be better to follow the example of the
surrounding clauses and an "AND NOT p.inherited" somewhere in the middle?

-- 
nathan



pgsql-hackers by date:

Previous
From: Jacob Champion
Date:
Subject: Re: Direction for test frameworks: Perl TAP vs. Python/pytest
Next
From: Robert Haas
Date:
Subject: Re: Improving the names generated for indexes on expressions