Re: pg_stat_statements: Remove (errcode...) framing parentheses in erport(...) - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: pg_stat_statements: Remove (errcode...) framing parentheses in erport(...)
Date
Msg-id aj4OqKRx-MABlXWw@paquier.xyz
Whole thread
List pgsql-hackers
On Thu, Jun 25, 2026 at 02:05:10PM -0700, Bharath Rupireddy wrote:
> +1 to what's said above. The merge burden is real (recently it took me
> more than 30 minutes just to create patches for back-branches even
> though most of the code remains the same in the function being
> changed). IMHO, it's not worth the cycles.

The unnecessary backpatching noise it the most annoying part.
ereport() code may use multiple levels of parenthesis, and that tends
to make the handling of the conflicts across branches quite annoying.
Let's keep this code as it is.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: vignesh C
Date:
Subject: Re: Proposal: Conflict log history table for Logical Replication
Next
From: Ajit Awekar
Date:
Subject: Re: Continuous re-validation of session credentials