Re: pgsql: doc: Clarify OAuth validator authn_id logging - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: pgsql: doc: Clarify OAuth validator authn_id logging
Date
Msg-id aiYFFH1kp_fGU9Xe@paquier.xyz
Whole thread
In response to Re: pgsql: doc: Clarify OAuth validator authn_id logging  (Erik Rijkers <er@xs4all.nl>)
List pgsql-hackers
On Sat, Jun 06, 2026 at 02:36:24PM +0200, Erik Rijkers wrote:
> In doc/src/sgml/oauth-validators.sgml, and if I understand this text
> correctly (always a big if), then:
>
> "If the validator returns true and set result->authn_id then"
>
> should be:
> "If the validator returns true and sets result->authn_id then"
>   (i.e., set -> sets)
>
> (added Michael in CC as he seems to collect these minimal patches, to be
> committed later as a group)

In auth-oauth.c, there is a validate() path setting the authn_id, so
your suggestion sounds right.  I've grabbed that for later.  My branch
can always be overwritten by somebody else's commit preference, of
course, so if you feel that this should be fixed separately, feel free
to go ahead.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Jim Vanns
Date:
Subject: Re: [PATCH] Add support for SAOP in the optimizer for partial index paths
Next
From: Michael Paquier
Date:
Subject: Re: Fix comments to reference xlogrecovery.c