Re: Adding REPACK [concurrently] - Mailing list pgsql-hackers

Hello,

On 2026-Apr-07, Hayato Kuroda (Fujitsu) wrote:

> 01.
> ```
> --- a/src/backend/access/index/genam.c
> +++ b/src/backend/access/index/genam.c
> @@ -394,6 +394,14 @@ systable_beginscan(Relation heapRelation,
>      SysScanDesc sysscan;
>      Relation    irel;
>  
> +    /*
> +     * If this backend promised that it won't access shared catalogs during
> +     * logical decoding, this it the right place to verify.
> +     */
> +    Assert(!HistoricSnapshotActive() ||
> +           accessSharedCatalogsInDecoding ||
> +           !heapRelation->rd_rel->relisshared);
> ```
> 
> Not sure it's OK to use Assert(). elog(ERROR) might be better if we want to really
> avoid the case.

How about the attached?

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/