Re: [PATCH] Compressed TOAST data corruption with REPACK CONCURRENTLY - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: [PATCH] Compressed TOAST data corruption with REPACK CONCURRENTLY
Date
Msg-id afPPnTzNNC3EupUA@alvherre.pgsql
Whole thread
In response to Re: [PATCH] Compressed TOAST data corruption with REPACK CONCURRENTLY  (Antonin Houska <ah@cybertec.at>)
List pgsql-hackers
On 2026-Apr-26, Antonin Houska wrote:

> I see you actually refer to the correct tests. I see no failure now as
> well. I'll try to make the tests more stable. Sorry for the confusion.

So, the reason this wasn't failing for me is that I had default TOAST
compression lz4, and the test case wasn't reaching size for being made
external, as opposed to pglz.  I changed the test to specify pglz
compression explicitly.  I also added some dropped columns and one more
toast column.  (On my machine, this expanded test fails for several
rows, not just one, when the fix is deactivated.)  I fear the buildfarm
may end up showing other failures, but there's no way to know other than
to try.

Thanks, Satya, for reporting the bug.

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/
"In fact, the basic problem with Perl 5's subroutines is that they're not
crufty enough, so the cruft leaks out into user-defined code instead, by
the Conservation of Cruft Principle."  (Larry Wall, Apocalypse 6)



pgsql-hackers by date:

Previous
From: Melanie Plageman
Date:
Subject: Re: Two issues leading to discrepancies in FSM data on the standby server
Next
From: Masahiko Sawada
Date:
Subject: Re: Startup process deadlock: WaitForProcSignalBarriers vs aux process