On Thu, May 07, 2026 at 10:59:26PM +0200, Daniel Gustafsson wrote:
> Attached is a patch against HEAD for this. Reading your mail my interpretation
> was that this was equally broken for MSVC even though the macro is correct
> there, and we should remove both. Was that a correct reading?
Yeah, atomics.h doesn't use the right macro for MSVC, so nothing in this
file is compiled for MSVC anyway. However, I suspect the proper fix is to
make sure this file is included for MSVC. Note that the other MSVC code in
this file is similarly broken, but fortunately isn't used anywhere [0].
> I'm not sure it's worth doing this to the backbranches, seems like we can keep
> this a v19+ fix.
+1
[0] https://postgr.es/m/afouZUH_eUkIj4i4%40nathan
--
nathan
