Re: some extra warnings from MSVC - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: some extra warnings from MSVC
Date
Msg-id aeVUvYQ_cXgiA_j4@paquier.xyz
Whole thread
In response to Re: some extra warnings from MSVC  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Sat, Apr 11, 2026 at 10:09:58AM -0400, Tom Lane wrote:
> I think it'd be a good idea to warn even if we can't make gcc do that.
> I think Windows is the only 64-bit platform we deal with where long
> is just 32 bits, so covering the case in MSVC will expose bugs we
> would not notice otherwise.

Interesting issue.  I did not notice this thread until 9018c7d37bb4.
Please do not hesitate to add me in CC in the future, as 13b935cd521
has my fingerprints.  Thanks for fixing the issue.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: [PATCH] Add tests for Bitmapset
Next
From: David Rowley
Date:
Subject: Re: Add bms_offset_members() function for bitshifting Bitmapsets