Request a Demo
Home   >   mailing lists

Re: [PATCH] Compressed TOAST data corruption with REPACK CONCURRENTLY - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [PATCH] Compressed TOAST data corruption with REPACK CONCURRENTLY
Date
Msg-id aeKnABrX4ShBtHkg@paquier.xyz
Whole thread
In response to Re: [PATCH] Compressed TOAST data corruption with REPACK CONCURRENTLY  (SATYANARAYANA NARLAPURAM <satyanarlapuram@gmail.com>)
List pgsql-hackers
Tree view 
On Fri, Apr 17, 2026 at 10:40:39AM -0700, SATYANARAYANA NARLAPURAM wrote:
> I started with that but tried to follow the existing code pattern. This
> LGTM.
> Please add a comment as well.

Hmm.  I was reading restore_tuple(), and could it make sense to expand
a bit more the tests so as more types of varlena pointers could be
checked in this routine?  I am taking about MAIN, EXTENDED and
EXTERNAL, so as we could check more patterns with in-line
[non-]compressed, and external [non-]compressed, counting for the four
different possible patterns that could lead to repacked data.  See for
example strings.sql for such tests, that could be used as base
inspiration.
--
Michael
Attachment

pgsql-hackers by date:

Previous
From: Jelte Fennema-Nio
Date:
Subject: Re: Add editorconfig support for Postgres spec files
Next
From: Michael Paquier
Date:
Subject: Re: [PATCH] Use direct hash lookup in logicalrep_partmap_invalidate_cb()