Re: [PATCH] allow src/tools/msvc/clean.bat script to be called from the root of the source tree - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: [PATCH] allow src/tools/msvc/clean.bat script to be called from the root of the source tree
Date
Msg-id ae44b04a-2087-fa9d-c6b1-b1dcbbacf4ae@dunslane.net
Whole thread Raw
In response to [PATCH] allow src/tools/msvc/clean.bat script to be called from the root of the source tree  (Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>)
Responses Re: [PATCH] allow src/tools/msvc/clean.bat script to be called from the root of the source tree
List pgsql-hackers
On 1/18/22 04:41, Juan José Santamaría Flecha wrote:
> In [1] capacity for $SUBJECT was added to most of the batch scripts,
> but clean.bat was not included. I propose to do so with the attached
> patch.


That looks a bit ugly. How about this (untested) instead?


>
> By the way, are pgbison.bat and pgflex.bat directly called anywhere?



Not to my knowledge. One of the things that's annoying about them is
that the processor names are hardcoded, so if you install winflexbison
as I usually do you have to rename the executables (or rename the
chocolatey shims) or the scripts won't work.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

Attachment

pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: Replace uses of deprecated Python module distutils.sysconfig
Next
From: Tom Lane
Date:
Subject: Re: Push down time-related SQLValue functions to foreign server