Re: Improve UX of YUM/DNF download form - Mailing list pgsql-www

From Jonathan S. Katz
Subject Re: Improve UX of YUM/DNF download form
Date
Msg-id ae207206-5c8c-21d5-3eb8-6dfb75bca7e5@postgresql.org
Whole thread Raw
In response to Re: Improve UX of YUM/DNF download form  (Dave Page <dpage@pgadmin.org>)
Responses Re: Improve UX of YUM/DNF download form  (Dave Page <dpage@pgadmin.org>)
List pgsql-www
On 6/9/20 7:58 AM, Dave Page wrote:
> So here's the updated patch following some discussion with Magnus:
>
> - Make the copyScript function more generic so it can be used elsewhere.
> - Don't include comments and blank lines in the copied text.
> - Move the css into main.css.
> - Add the actual install step to the Debian/Ubuntu instructions.
> - Improve naming of vars, classes, ids etc.
> - Ensure the copyScript function works fine with < > and so-on in the
> script.

That certainly changed a lot overnight ;)

LGTM. I don't have any additional comments on it, so I will give a +1.

Jonathan


Attachment

pgsql-www by date:

Previous
From: Dave Page
Date:
Subject: Re: Improve UX of YUM/DNF download form
Next
From: Dave Page
Date:
Subject: Re: Improve UX of YUM/DNF download form