Re: Portable StaticAssertExpr - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Portable StaticAssertExpr
Date
Msg-id ae0c57e7-eb9a-4f00-9595-ebb1d7eb94fb@eisentraut.org
Whole thread Raw
In response to Re: Portable StaticAssertExpr  (Jelte Fennema-Nio <postgres@jeltef.nl>)
List pgsql-hackers
On 27.02.26 11:48, Jelte Fennema-Nio wrote:
> On Mon, 23 Feb 2026 at 08:00, Peter Eisentraut <peter@eisentraut.org> wrote:
>> In this patch, I'm proposing a different implementation that doesn't
>> require nonstandard extensions.
> 
> I tried this out in one of my WIP patches for for better C++ and it
> works correctly indeed.

Thanks, I have committed this.

> Small nit, instead of nesting ifdefs. I think this looks a bit nicer:
> 
> # ifdef __cplusplus
> ...
> #elif !defined(_MSC_VER) || _MSC_VER >= 1933
> ...
> #else
> ...
> #endif

I didn't change this, because I think it is better to keep the C code 
first and then the C++ as an alternate variant last (which is also 
existing style, at least in some parts), even if this requires some 
additional logical negations.




pgsql-hackers by date:

Previous
From: vignesh C
Date:
Subject: Re: Skipping schema changes in publication
Next
From: Maciek Sakrejda
Date:
Subject: Re: V18 change on EXPLAIN ANALYZE