Re: Reduce build times of pg_trgm GIN indexes - Mailing list pgsql-hackers

From Bertrand Drouvot
Subject Re: Reduce build times of pg_trgm GIN indexes
Date
Msg-id adzNqZdHrWHYCinj@ip-10-97-1-34.eu-west-3.compute.internal
Whole thread Raw
In response to Re: Reduce build times of pg_trgm GIN indexes  (Peter Eisentraut <peter@eisentraut.org>)
Responses Re: Reduce build times of pg_trgm GIN indexes
List pgsql-hackers
Hi,

On Mon, Apr 13, 2026 at 11:41:02AM +0200, Peter Eisentraut wrote:
> On 09.04.26 13:28, Bertrand Drouvot wrote:
> > 
> > This commit makes use of StaticAssertStmt() that has been deprecated in
> > d50c86e74375. The attached, fixes it.
> 
> I think the position of the static assertion is correct, because it refers
> to the palloc0_array() that follows.  Maybe the comment could be a bit
> clearer, like "using palloc0_array requires GIN_CAT_NORM_KEY==0"?

Yeah that looks better to not lose the connection with palloc0_array() here.
Done that way in the attached and adding new braces to avoid warning from
-Wdeclaration-after-statement.

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

Attachment

pgsql-hackers by date:

Previous
From: Dean Rasheed
Date:
Subject: Re: Bug: Rule actions see wrong values for generated columns (NEW.gen reads OLD value)
Next
From: Alexander Korotkov
Date:
Subject: Re: Re: Bug: WAIT FOR LSN crashes with assertion failure inside PL/pgSQL DO blocks and procedures