Re: Forbid to DROP temp tables of other sessions - Mailing list pgsql-hackers

Hi,

I have some comments:

1. namespace.c, if relation->schemaname is pg_temp but myTempNamespace 
isn't set, the error information might be misleading. Consider checking 
OidIsValid(myTempNamespace) first.

2."you have not any temporary relations" --> "you have no any temporary 
relations"

3. Regarding to the code "strncmp(nspname, "pg_temp", 7)", is it ok when 
the nspname contains something like "pg_temp_1234"? I think we should 
use strcmp instead of strncmp for exact matching.

Thanks,
Steven

在 2025/3/17 17:03, Daniil Davydov 写道:
> Hi,
> I see that the presence of isolation tests in the patch is
> controversial. First things first, let's concentrate on fixing the
> bug.
> I attach a new version of patch (for `master` branch) to this letter.
> It contains better comments and a few small improvements.
> 
> P.S.
> Sorry for bad formatting in previous letter (idk how to fix it in gmail client)
> 
> --
> Best regards,
> Daniil Davydov