Hi,
On Wed, Apr 01, 2026 at 07:54:07AM +0200, Peter Eisentraut wrote:
> On 31.03.26 11:09, Jelte Fennema-Nio wrote:
> > On Tue, 31 Mar 2026 at 10:33, Peter Eisentraut <peter@eisentraut.org> wrote:
> > > Hmm, note that C++ is also used for LLVM/JIT, and by requiring this
> > > additional feature set we are also imposing new requirements for those
> > > users. This has not been fully explored, and I hesitate to add such a
> > > new requirement at the last moment.
> >
> > I understand the hesitation, but in practice we already impose those
> > requirements anyway for non-MSVC compilers because test_cplusplusext
> > doesn't compile without it. So any compiler that would cause problems
> > with the new featureset would have already complained about that
> > before.
> >
> > > But how about this: We add the feature test that you propose and enable
> > > the extension based on that. See attached patch. This reduces to
> > > essentially a three-line patch, much simpler than all previous proposals.
> >
> > If you're still worried, then this sounds like a fine middle-ground
> > for now. I think we should reconsider adding the automatic /std:c++20
> > flag for the PG20 dev cycle though.
>
> Ok, I have committed the shown patch.
d50c86e74375 added a comment mentionning that StaticAssertStmt is deprecated, so
we really need the one added in test_cplusplusext.cpp?
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
