Postgres Pro
Downloads
Home   >   mailing lists

Re: Patch for bug #17056 fast default on non-plain table - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: Patch for bug #17056 fast default on non-plain table
Date
Msg-id adb8d13a-75e2-e4b7-dff8-eb3ea12d03b3@dunslane.net
Whole thread Raw
In response to Re: Patch for bug #17056 fast default on non-plain table  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Patch for bug #17056 fast default on non-plain table
List pgsql-hackers
Tree view 
On 6/17/21 11:05 AM, Tom Lane wrote:
> Andrew Dunstan <andrew@dunslane.net> writes:
>> Here's a patch I propose to apply to fix this bug (See
>>
<https://www.postgresql.org/message-id/flat/759e997e-e1ca-91cd-84db-f4ae963fada1%40dunslane.net#b1cf11c3eb1f450bed97c79ad473909f>)
> If I'm reading the code correctly, your change in RelationBuildTupleDesc
> is scribbling directly on the disk buffer, which is surely not okay.
> I don't understand why you need that at all given the other defenses
> you added ... but if you need it, you have to modify the tuple AFTER
> copying it.


OK, will fix. I think we do need it (See Andres' comment in the bug
thread). It should be a fairly simple fix.


Thanks for looking.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Patch for bug #17056 fast default on non-plain table
Next
From: Matthias van de Meent
Date:
Subject: Re: Iterating on IndexTuple attributes and nbtree page-level dynamic prefix truncation