Re: Shmem allocated wrong for custom cumulative stats - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Shmem allocated wrong for custom cumulative stats
Date
Msg-id adR0Q9NO2jbLiQuM@paquier.xyz
Whole thread Raw
In response to Re: Shmem allocated wrong for custom cumulative stats  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
On Mon, Apr 06, 2026 at 12:14:06PM +0900, Michael Paquier wrote:
> The attached is working correctly.  The v18 flavor is slightly
> simpler.

I have looked at it again today, and noticed that the test modules of
both HEAD and REL_18_STABLE were incorrect in the values they set for
shared_size for the fixed-sized cases.  In both cases we were
finishing with an underestimation.  I could only see a direct impact
on HEAD for the 32-bit builds, though, but the problem was the same.

The allocation has been fixed in 17132f55c5a2, with the modules
handled by 98979578055f.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Fujii Masao
Date:
Subject: Re: pgsql: Reduce log level of some logical decoding messages from LOG to D
Next
From: Andres Freund
Date:
Subject: Re: Implement waiting for wal lsn replay: reloaded