On 15/07/2026 19:14, Álvaro Herrera wrote:
>> Shouldn't this be extern *PGDLLIMPORT* bool ... ?
>
> Did you hit a problem with it? If so, what was it?
Not a problem per se, rather a small inconsistency.
Since commit
8ec569479fc Apply PGDLLIMPORT markings broadly. (2022-04-08) <Robert Haas>
it seems to be a rule to mark all variables in .h files as PGDLLIMPORT.
Perhaps, except frontend-only ones.
As for now,
$ find src/include -type f -print0 | xargs -0 src/tools/mark_pgdllimport.pl
src/include/common/logging.h: adding 1 PGDLLIMPORT markers
src/include/postmaster/syslogger.h: adding 1 PGDLLIMPORT markers
modifies only two lines in two files. And common/logging.h is a
frontend-only, so it's a natural exception. So I think there is no need
to add another exception without explicit reasons, even though you are
right and it's hard for me to think of a realistic need to refer to that
variable from an extension.
--
Anton Voloshin
https://postgrespro.com
