Request a Demo
Home   >   mailing lists

Re: Fixes inconsistent behavior in vacuum when it processes multiple relations - Mailing list pgsql-hackers

From Nathan Bossart
Subject Re: Fixes inconsistent behavior in vacuum when it processes multiple relations
Date
Msg-id acVZ2O0938nWa73w@nathan
Whole thread Raw
In response to Re: Fixes inconsistent behavior in vacuum when it processes multiple relations  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Fixes inconsistent behavior in vacuum when it processes multiple relations
List pgsql-hackers
Tree view 
On Thu, Mar 26, 2026 at 11:22:25AM +0900, Michael Paquier wrote:
> Once vacuum_rel() has its VacuumParams changed to a pointer, renaming
> it to params_local and use params_local in all its code paths looks
> sensible.  On top of what you are doing, I would add a big warning
> comment at the top of the routine to mention that "params" should not
> be used directly in the routine.  The local copies should be used.

Wait...  Can't we just pass params by value only to vacuum_rel()?  Doesn't
this accomplish what we need?

-- 
nathan
Attachment

pgsql-hackers by date:

Previous
From: Tomas Vondra
Date:
Subject: Re: eliminate xl_heap_visible to reduce WAL (and eventually set VM on-access)
Next
From: Tom Lane
Date:
Subject: Re: [PATCH] pgindent truncates last line of files missing a trailing newline