Re: Conflict between regression tests namespace & transactions due to recent changes - Mailing list pgsql-hackers

From Marina Polyakova
Subject Re: Conflict between regression tests namespace & transactions due to recent changes
Date
Msg-id ac5bfbf1012b59f56af5ad6715adc0d3@postgrespro.ru
Whole thread Raw
In response to Re: Conflict between regression tests namespace & transactions due to recent changes  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Conflict between regression tests namespace & transactions due to recent changes
List pgsql-hackers
On 2023-05-16 02:19, Michael Paquier wrote:
> On Mon, May 15, 2023 at 11:23:18PM +0300, Marina Polyakova wrote:
>> Maybe use a separate schema for all new objects in the transaction 
>> test?..
>> See diff_set_tx_schema.patch.
> 
> Sure, you could do that to bypass the failure (without the "public"
> actually?), leaving non-generic names around.  Still I'd agree with
> Tom here and just rename the objects to something more in line with
> the context of the test to make things a bit more greppable.  These
> could be renamed as transaction_tab or transaction_view, for example.
> --
> Michael

It confuses me a little that different methods are used for the same 
purpose. But the namespace test checks schemas. So see 
diff_abc_to_txn_table.patch which replaces abc with txn_table in the 
transaction test.

-- 
Marina Polyakova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Autogenerate some wait events code and documentation
Next
From: Daniel Gustafsson
Date:
Subject: Re: Using make_ctags leaves tags files in git