Re: tablecmds: reject CLUSTER ON for partitioned tables earlier - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: tablecmds: reject CLUSTER ON for partitioned tables earlier
Date
Msg-id abfElj6aqmazkgb1@paquier.xyz
Whole thread Raw
In response to Re: tablecmds: reject CLUSTER ON for partitioned tables earlier  (Chao Li <li.evan.chao@gmail.com>)
Responses Re: tablecmds: reject CLUSTER ON for partitioned tables earlier
List pgsql-hackers
On Fri, Mar 13, 2026 at 11:38:17AM +0800, Chao Li wrote:
> On Jan 28, 2026, at 10:15, Chao Li <li.evan.chao@gmail.com> wrote:
>> * In 0001, replaced ereport with assert in
>> mark_index_clustered(). See my previous email for the analysis.

I have looked at this one, and I think that it is right.  Even in the
CLUSTER/VACUUM path, we have a relkind check before the sole caller of
rebuild_relation() that discards partitioned tables, so we would never
read mark_index_clustered() under this relkind.  Applied.

>> * In 0002, removed the redundant check of relispartition from
>> * ATExecDropInherit().

I have not looked at this one.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Skipping schema changes in publication
Next
From: Ashutosh Sharma
Date:
Subject: Re: synchronized_standby_slots behavior inconsistent with quorum-based synchronous replication