Re: MSVC: Improve warning options set - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: MSVC: Improve warning options set
Date
Msg-id ab398bb9-23a9-4c61-8b54-2b5dd9b87779@eisentraut.org
Whole thread Raw
In response to Re: MSVC: Improve warning options set  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
On 03.11.25 20:26, Andres Freund wrote:
> On 2025-11-03 19:56:16 +0100, Peter Eisentraut wrote:
>> I don't know if we still support MSVCRT if using MSVC, or how long we still
>> need to support it.  (Or, for example, how to tell which variant CI or the
>> buildfarm uses.)
> 
> To my knowledge anything close to a recent version visual studio / msvc don't
> use msvcrt anymore. Starting at least with VS 2015. I don't think our code
> would really work when building against msvcrt anyway (mingw worked for
> longer, because they added additional functionality in wrapper libraries,
> IIRC).

I have committed both of the patches as proposed, and both relevant 
buildfarm members have had no complaints.




pgsql-hackers by date:

Previous
From: Jim Jones
Date:
Subject: Re: [PATCH] Add pg_get_tablespace_ddl() function to reconstruct CREATE TABLESPACE statement
Next
From: Tom Lane
Date:
Subject: Re: Use bsearch() instead of a manual binary search in syscache.c