Re: Add pg_stat_recovery system view - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Add pg_stat_recovery system view
Date
Msg-id aapRWdyQYT6kC-k2@paquier.xyz
Whole thread Raw
In response to Re: Add pg_stat_recovery system view  (Xuneng Zhou <xunengzhou@gmail.com>)
Responses Re: Add pg_stat_recovery system view
Re: Add pg_stat_recovery system view
List pgsql-hackers
On Thu, Mar 05, 2026 at 09:01:35PM +0800, Xuneng Zhou wrote:
> Here is the updated patch set. Please take a look.

Thanks.  It was mostly fine, still:
- The extra mention of ROLE_PG_READ_ALL_STATS was not necessary.  We
already have one at the top of the section.
- After sleeping on it, I have decided to keep recoveryLastXTime,
partially because we have a system function to retrieve it already.
- There was a refactoring piece possible when we switch a
RecoveryPauseState to a non-translatable string, which I have applied
separately.
- Added one test with pg_stat_recovery checked on a standby.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Chao Li
Date:
Subject: Mis-use of type BlockNumber?
Next
From: David Rowley
Date:
Subject: Re: More speedups for tuple deformation