Re: [BUGFIX] Fix crash due to sizeof bug in RegisterExtensionExplainOption - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [BUGFIX] Fix crash due to sizeof bug in RegisterExtensionExplainOption
Date
Msg-id aaUBeYzQTw5AETZh@paquier.xyz
Whole thread Raw
In response to [BUGFIX] Fix crash due to sizeof bug in RegisterExtensionExplainOption  ("Joel Jacobson" <joel@compiler.org>)
List pgsql-hackers
On Sun, Mar 01, 2026 at 06:10:10PM +0100, Joel Jacobson wrote:
> The allocations in src/backend/commands/explain_state.c
> used sizeof(char *) instead of sizeof(ExplainExtensionOption),
> which could cause a crash if an extension would register
> more than 8 extension EXPLAIN options:

Indeed, that's wrong as-is.  The problem can be reproduced simply by
saving more options into pg_overexplain, as well, leading to the same
memory chunk issues.  Will fix, thanks for the report.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: zhanghu
Date:
Subject: Re: guc: make dereference style consistent in check_backtrace_functions
Next
From: jinbinge
Date:
Subject: Re: pg_resetwal.c: duplicate '0' in hex character set for -l option validation