Re: BUG: Former primary node might stuck when started as a standby - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: BUG: Former primary node might stuck when started as a standby
Date
Msg-id aaU5EiNHfyMb9Bvu@paquier.xyz
Whole thread Raw
In response to Re: BUG: Former primary node might stuck when started as a standby  (Alexander Lakhin <exclusion@gmail.com>)
Responses RE: BUG: Former primary node might stuck when started as a standby
List pgsql-hackers
On Mon, Mar 02, 2026 at 09:00:00AM +0200, Alexander Lakhin wrote:
> As it turned out, v2 patch works as expected, but the test may still fail
> when the build is configured without injection points. Maybe this test (
> and similar one(s)) should be skipped in this case, not sure...

Exactly, I don't see what else we can do here except skip the
sequences of the test that we know may fail if injection points are
not enabled in the build.

Looking at v2, the patch ought to comment the reason *why* these tests
are skipped and *why* an injection point is used.  The reader should
have more details than just a small hint about a set of "random
failures".  I'd suggest to document that once with the first injection
point attached, and have the other blocks hold comments telling to
look at the first block.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Chao Li
Date:
Subject: Re: guc: make dereference style consistent in check_backtrace_functions
Next
From: Michael Paquier
Date:
Subject: Re: DOCS - pg_walsummary typo?