Request a Demo
Home   >   mailing lists

Re: pg_resetwal.c: duplicate '0' in hex character set for -l option validation - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: pg_resetwal.c: duplicate '0' in hex character set for -l option validation
Date
Msg-id aaT09KfuMqMcLakl@paquier.xyz
Whole thread Raw
In response to pg_resetwal.c: duplicate '0' in hex character set for -l option validation  (jinbinge <jinbinge@126.com>)
Responses Re: pg_resetwal.c: duplicate '0' in hex character set for -l option validation
List pgsql-hackers
Tree view 
On Mon, Mar 02, 2026 at 10:13:38AM +0800, jinbinge wrote:
> "0123456789ABCDEFabcdef". This change would be purely cosmetic with
> no behavioral impact, but would eliminate the unnecessary
> duplication.

That's entirely cosmetic, well why not..  There is also a
01234567890ABCDEF in src/bin/pg_upgrade/controldata.c.  Perhaps we
could sanitize the whole as of 0123456789ABCDEF, which is larger in
trend compared to 1234567890ABCDEF when it comes to the C code, not
the tests.
--
Michael
Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Defects with invalid stats data for expressions in extended stats
Next
From: Sami Imseih
Date:
Subject: Re: Fix bug in multixact Oldest*MXactId initialization and access