Re: Defects with invalid stats data for expressions in extended stats - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Defects with invalid stats data for expressions in extended stats
Date
Msg-id aaFIxLbHgbm6Wo5m@paquier.xyz
Whole thread Raw
In response to Re: Defects with invalid stats data for expressions in extended stats  (Chao Li <li.evan.chao@gmail.com>)
Responses Re: Defects with invalid stats data for expressions in extended stats
List pgsql-hackers
On Fri, Feb 27, 2026 at 02:51:40PM +0800, Chao Li wrote:
> Here stats itself is destroyed, but memory pointed by
> stats[0]~stats[i-1] are not free-ed, those memory are returned from
> examine_attribute() by palloc0_object().

I am aware of that.  This is not done on simplicity ground, keeping
the cleanup of the memory context to ANALYZE in this case.

> “This function returns sets …”, is “returns” a typo and not needed?

That's a typo, thanks for re-reading.

> The comment says “this function does not use a function body”, but
> the function has a body. This appears in two places.

Let's just append a "SQL-standard" here, then.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Funny behavior in event trigger code with CREATE OR REPLACE VIEW and column additions
Next
From: Peter Eisentraut
Date:
Subject: Re: SQL Property Graph Queries (SQL/PGQ)