On Thu, Feb 26, 2026 at 10:52:48PM -0500, Corey Huinker wrote:
> Patch applies for me, but there seems to be some user-specific stuff in the
> test, which causes it to fail:
Yep. I've noticed that in the CI a few minutes ago. I have switched
the tests to use a query where the owner does not show up, leading to
the same coverage without the user-dependency blip. I have checked
that this version cools down the CI.
> A nitpick about the test - it uses a plpgsql function when we've been
> moving such trivial functions to SQL standard function bodies for a while
> now, and they were introduced back in v14 so there's no backporting
> concern.
No, that's on purpose. Using a SQL function with a body would not
trigger the problem with the stats loaded at the end of the SQL test
as we would skip the fatal call of statext_expressions_load(). Based
on your confusion, I guess that a note to document that is in order,
at least, so as nobody comes with the idea of changing the definition
of this function..
--
Michael
