Request a Demo
Home   >   mailing lists

Re: Use pg_icu_unicode_version(void) instead of pg_icu_unicode_version() - Mailing list pgsql-hackers

From Bertrand Drouvot
Subject Re: Use pg_icu_unicode_version(void) instead of pg_icu_unicode_version()
Date
Msg-id aaE9ibod8ILJhAga@ip-10-97-1-34.eu-west-3.compute.internal
Whole thread Raw
In response to Re: Use pg_icu_unicode_version(void) instead of pg_icu_unicode_version()  (Chao Li <li.evan.chao@gmail.com>)
Responses Re: Use pg_icu_unicode_version(void) instead of pg_icu_unicode_version()
List pgsql-hackers
Tree view 
Hi,

On Fri, Feb 27, 2026 at 02:04:30PM +0800, Chao Li wrote:
> 
> 
> What I'm interested in is the broader policy: when reviewing patches,
> if we encounter a foo() declaration, should we consistently request a change to foo(void)?
> If yes, the standard should be documented somewhere.

I think that they should be consistently fixed for the reasons mentioned in 
[1], and that the best way to achieve this goal would be to enable -Wstrict-prototypes
by default ([2]).

[1]: https://postgr.es/m/aTBObQPg%2Bps5I7vl%40ip-10-97-1-34.eu-west-3.compute.internal
[2]: https://postgr.es/m/aTJ9T8HyJN3D024w%40ip-10-97-1-34.eu-west-3.compute.internal

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

pgsql-hackers by date:

Previous
From: vignesh C
Date:
Subject: Re: Skipping schema changes in publication
Next
From: Chao Li
Date:
Subject: Re: Defects with invalid stats data for expressions in extended stats