On 11.04.2025 20:09, David G. Johnston wrote:
However, I do think we are at something committable, though I'd make one, maybe two, changes to v8.
Thank you for supporting this patch.
Valid until -> Password valid until: the timestamp value already forces a wide column, adding the word Password to the header to clarify what is valid simply provides the same context that the create role page provides when it shows the valid until attribute immediately below the password attribute. Leaving "valid until" alone retains the attribute name tieback.
Connection limit -> Con. limit: maybe this gets rejected on translation grounds but the abbreviation here seems obvious and shaves 7 characters off the mandatory width for a column that occupies 12 characters more than the values require.
Yes, it can be done.
<bikeshedding again>
I still have some doubts about these columns. Possibly these columns changes very rare,
not very often. So, maybe a better solution is to show them only in \du+.
In such case wide of columns is not a problem. But such change requires changing
"Attributes" column back to one line.
</bikeshedding>
Even without those changes I as reviewer would concur with the proposal and try to move this on from bike-shedding to a go/no-go decision (by marking it Ready to Commit) as to whether this is an improvement over the status quo.
Since the patch requires rebase and implementation of your suggestions, I decided to move the entry to the next (July) commitfest and set the status to "Waiting on Author". I hope that I will return to this work in June. Robert's idea (detailed role permissions report with \du rolename) can be implemented as a separate work. --
Pavel Luzanov
Postgres Professional: https://postgrespro.com
