Hi,
On Thu, Feb 19, 2026 at 04:08:59PM -0600, Sami Imseih wrote:
> > > Not a fan of the hardcoded sleeps in the tests, either.
> >
> > Yeah, after our off-list discussion yesterday, I tried to implement the same
> > trick that f1e251be80a has done with injection points (nice trick by the way!),
PFA, a tiny ("include") rebase due to 9842e8aca09 (the v9 patch series was applying
but not compiling).
> I took a look at this today out of interest,
Thanks!
> so, instead of calling IS_INJECTION_POINT_ATTACHED macro which is
I think that not calling IS_INJECTION_POINT_ATTACHED() but only relying on
"ifdef USE_INJECTION_POINTS" would set the tiny timeout value to the entire test
suit.
I'm waiting for Michael's feedback about the current design ([1]) to see if it's
still worth spending time improving the tests.
[1]: https://postgr.es/m/aZbDYMrOkeCyIubO%40ip-10-97-1-34.eu-west-3.compute.internal
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
