Re: Our ABI diff infrastructure ignores enum SysCacheIdentifier - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Our ABI diff infrastructure ignores enum SysCacheIdentifier
Date
Msg-id aZQt88RiILCwqCMq@paquier.xyz
Whole thread Raw
In response to Re: Our ABI diff infrastructure ignores enum SysCacheIdentifier  (Andreas Karlsson <andreas@proxel.se>)
Responses Re: Our ABI diff infrastructure ignores enum SysCacheIdentifier
List pgsql-hackers
On Tue, Feb 17, 2026 at 09:20:44AM +0100, Andreas Karlsson wrote:
> Yeah, that looks like a quite nice improvement. My only comment is that if
> it was me I would have split it into two patches, one introducing the
> invalid and one replacing int. But you are much more familiar than me with
> what granularity of commits the project prefers

Splitting that into two is probably better, yes.  Even if both changes
touch the same portions of perl script, it makes the introduction of
the two concepts cleaner.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Corey Huinker
Date:
Subject: Re: generating function default settings from pg_proc.dat
Next
From: Tatsuo Ishii
Date:
Subject: Re: Row pattern recognition