Re: Fix wrong log in pgstat_report_checksum_failures_in_db() - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Fix wrong log in pgstat_report_checksum_failures_in_db()
Date
Msg-id aYxiuJWyXZmnab4T@paquier.xyz
Whole thread Raw
In response to Fix wrong log in pgstat_report_checksum_failures_in_db()  (wangpeng <215722532@qq.com>)
Responses Re: Fix wrong log in pgstat_report_checksum_failures_in_db()
List pgsql-hackers
On Wed, Feb 11, 2026 at 05:22:27PM +0800, wangpeng wrote:
> The function pgstat_report_checksum_failures_in_db(), file
> pgstat_database.c,
> currently emits a log message referring to "conflicts", which seems wrong.
> As the function name suggesting, the log message should refer to "checksum
> failures".

Right, that's strange.  It looks like a copy-pasto, but I am not sure
from where.

> -        elog(WARNING, "could not report %d conflicts for DB %u",
> +        elog(WARNING, "could not report %d checksum failures for DB %u",
>               failurecount, dboid);

We may as well use "for database" here.  Let's improve it a bit more
while on it, even if it is not translated.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Bertrand Drouvot
Date:
Subject: Re: PGPROC alignment (was Re: pgsql: Separate RecoveryConflictReasons from procsignals)
Next
From: Gilles Darold
Date:
Subject: Re: Pasword expiration warning