Re: Report bytes and transactions actually sent downtream - Mailing list pgsql-hackers

Hi,

On Mon, Feb 02, 2026 at 02:06:07PM +0530, Ashutosh Bapat wrote:
> On Tue, Jan 27, 2026 at 11:08 PM Andres Freund <andres@anarazel.de> wrote:
> >
> > Hi,
> >
> > On 2025-12-11 10:29:42 +0530, Ashutosh Bapat wrote:
> > > Please review.
> >
> > I'd simplify the patch to, initially, to just track the sent bytes.  For one,
> > that's by *far* the most useful statistic.  But I also have some concerns
> > about the other stats:
> >
> 
> Ok. I have split the patch into two

Thanks!

> 0001 to track sent_bytes
> 0002 to track filtered_bytes and sent_txns
> 
> I think we all agree that sent_bytes is useful, so I suggest that we
> review and commit 0001.

I had a look at 0001 and it looks ok to me. That's an extract of the previous
patches that we already iterated over up-thread.

I just have a few more comments:

1/ commit message

s/This statistics/This statistic/

2/ LogicalOutputWrite

+   /* Update the amount of data sent downstream. */

I think we can remove the period to be consistent with most of the one line
comments around.

3/ WalSndWriteData

Same as 2/., remove the period for the same comment.

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com