Re: basic_archive lost archive_directory - Mailing list pgsql-bugs

From Nathan Bossart
Subject Re: basic_archive lost archive_directory
Date
Msg-id aYpWFcfk1xueHiCc@nathan
Whole thread Raw
In response to Re: basic_archive lost archive_directory  (Fujii Masao <masao.fujii@gmail.com>)
Responses Re: basic_archive lost archive_directory
List pgsql-bugs
On Tue, Feb 10, 2026 at 02:46:39AM +0900, Fujii Masao wrote:
> Basically I like the idea of moving the checks for archive_directory from
> check_archive_directory() to basic_archive_configured(). This would not only
> address this issue, but also other problems caused by performing these checks
> in the GUC check hook.

Note that the check_configured_cb is called for every segment to archive.
That means we'd be calling stat() much more, which seems like unnecessary
overhead to me.  And we still need to be prepared for the archive directory
to disappear at any time.  I'm wondering if it would be better to simply
remove this archive directory existence check from the check_configured_cb.

-- 
nathan



pgsql-bugs by date:

Previous
From: Sergei Kornilov
Date:
Subject: Re: basic_archive lost archive_directory
Next
From: Nathan Bossart
Date:
Subject: Re: basic_archive lost archive_directory