On Wed, Jan 14, 2026 at 06:24:56AM +0100, Laurenz Albe wrote:
> On Mon, 2025-12-15 at 15:30 +0100, David Bidoc wrote:
> > I attached the rebased and updated patch.
>
> That patch looks good to me, and I think that is a useful addition.
>
> If you want to display the path of databases as well, as you tried to
> do in the original patch, I think the way to go would be to write a
> new SQL function pg_database_filepath() similar to pg_relation_filepath().
> That shouldn't be too hard - would you want to try that?
>
> Other than that, you could try to propose a commit message and
> prepare your patch with
>
> git format-patch -v5 -1 -o /mypatches HEAD
>
> after committing it to your branch. That would make the committer's
> work easier.
I took a look with Phil Alger and we just have a couple of cosmetic
suggestions.
* There is an extra period (.) added to the change in the documentation.
* We would suggest using "Path" instead of "Filepath" in the column
name. While "Filepath" more closely reflects the the function used,
"Path" reads a little more smoothly, and text in existing
documentation tends to only reads "path" instead of "file path" when
referring to paths on the filesystem.
Regards,
Mark
--
Mark Wong <markwkm@gmail.com>
EDB https://enterprisedb.com
