Re: Consistently use the XLogRecPtrIsInvalid() macro - Mailing list pgsql-hackers

From Bertrand Drouvot
Subject Re: Consistently use the XLogRecPtrIsInvalid() macro
Date
Msg-id aXyTCrlkoewFa9lD@ip-10-97-1-34.eu-west-3.compute.internal
Whole thread Raw
In response to Re: Consistently use the XLogRecPtrIsInvalid() macro  (Álvaro Herrera <alvherre@kurilemu.de>)
List pgsql-hackers
Hi,

On Thu, Jan 29, 2026 at 06:45:12PM +0100, Álvaro Herrera wrote:
> On 2025-Nov-17, Bertrand Drouvot wrote:
> 
> > On Mon, Nov 17, 2025 at 01:12:24PM +0000, Bertrand Drouvot wrote:
> > > The script has been updated and the patch too (finding a new replacement in
> > > gist.c).
> > 
> > Finally, adding GistNSN to the game (as a typedef XLogRecPtr) gives the attached.
> 
> I've pushed this.

Thanks!

I just looked at the cocci script used for that and realized (with more Coccinelle
practice) that it could be simplified. It's done in [1], and lead to a few more
cases discovered and fixed in the attached. I think that, with the attached, we
cover them all.

[1]: https://github.com/bdrouvot/coccinelle_on_pg/blob/main/replace_literal_0_assignement_with_InvalidXLogRecPtr.cocci

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

Attachment

pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Re: More speedups for tuple deformation
Next
From: "Hayato Kuroda (Fujitsu)"
Date:
Subject: RE: Parallel Apply