On Thu, Jan 29, 2026 at 10:48:39PM +0100, Gilles Darold wrote:
> Le 29/01/2026 à 18:53, Nathan Bossart a écrit :
>> Having a variable for warning messages could come in handy later. For
>> example, we might add a warning about using MD5 passwords at some point.
>> In my draft patch for this [0], I put the warning after closing the
>> transaction, whereas this patch puts it just before. I'm not sure I had a
>> principled reason for doing so, but it's an interesting difference between
>> the two patches.
>
> Understood, I will rewrite the patch to use a int variable.
Sorry if my note was not clear, but I didn't mean to suggest rewriting
anything here. I thought the difference in placement for the warning
between your patch and mine was interesting, but I'm not sure there's
anything wrong that needs to be changed.
--
nathan
