Re: tablecmds: reject CLUSTER ON for partitioned tables earlier - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: tablecmds: reject CLUSTER ON for partitioned tables earlier
Date
Msg-id aXhty3YQceFniabz@paquier.xyz
Whole thread Raw
In response to Re: tablecmds: reject CLUSTER ON for partitioned tables earlier  (Chao Li <li.evan.chao@gmail.com>)
Responses Re: tablecmds: reject CLUSTER ON for partitioned tables earlier
Re: tablecmds: reject CLUSTER ON for partitioned tables earlier
List pgsql-hackers
On Tue, Jan 27, 2026 at 07:13:04AM +0800, Chao Li wrote:
> I added two new test cases in 0002 that trigger the check.
>
> BTW, this is the CF entry:
> https://commitfest.postgresql.org/patch/6415/. You may mark yourself
> as a reviewer, and once you consider the patch is ready to go, would
> you mind change the status to Ready For Committer?

There is more to this set of changes than it looks at first sight.

Hence, one question about 0001: can the previous error path in
mark_index_clustered() be reached through a different mean than ALTER
TABLE?  If yes, we should have a test for it.  If no, it could be
switched to an elog(ERROR) or an assertion.  The code paths leading to
the previous error should be analyzed further.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: tablecmds: fix bug where index rebuild loses replica identity on partitions
Next
From: Ajay Pal
Date:
Subject: Re: pg_plan_advice