Re: Some tests for TOAST, STORAGE MAIN/EXTENDED - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Some tests for TOAST, STORAGE MAIN/EXTENDED
Date
Msg-id aXVn-xg0bdPc0aGM@paquier.xyz
Whole thread Raw
In response to Re: Some tests for TOAST, STORAGE MAIN/EXTENDED  (Nikhil Kumar Veldanda <veldanda.nikhilkumar17@gmail.com>)
Responses Re: Some tests for TOAST, STORAGE MAIN/EXTENDED
List pgsql-hackers
On Fri, Jan 23, 2026 at 12:25:33AM -0800, Nikhil Kumar Veldanda wrote:
> The `SELECT count(*) FROM :reltoastname` assertion is a bit brittle
> for `STORAGE EXTENDED`: depending on the toast compression method /
> effectiveness, the value may end up as >1 chunk, which would flip the
> expected count(*) = 1. Prefer SELECT count(DISTINCT chunk_id) FROM
> :reltoastname (or WHERE chunk_seq = 0) and adjust expected.

Yeah, this suggestion sounds sensible and that would still notice what
I was able to break.

> pg_column_compression() expects pglz, but default_toast_compression
> isn’t pinned here. Suggest SET default_toast_compression = 'pglz';
> near this block; otherwise this can fail on builds with a different
> default.

Agreed, let's do that as well.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: "David E. Wheeler"
Date:
Subject: Re: ABI Compliance Checker GSoC Project
Next
From: Tom Lane
Date:
Subject: Re: Buffer locking is special (hints, checksums, AIO writes)