On Wed, Jan 21, 2026 at 08:40:16PM +0800, Xuneng Zhou wrote:
> Please see v5 of the updated patch.
This seems acceptable here, cool.
Something worth a note: I thought that the states of the WAL sender
were documented already, and I was wrong in thinking that it was the
case. Sorry. :)
By the way, the list of state values you are specifying in the patch
is not complete. In theory, we allow all state values like "stopped"
to show up in a single function call of pg_stat_get_wal_receiver(),
but you are not documenting all of them. Using a list (like with the
<itemizedlist> markup) would be better.
The documentation improvement can be treated as a separate change,
worth its own before adding the new "connecting" state. Could you
split that into two patches please? That would make one patch for
the documentation changes with the list of state values that can be
reported, and a second patch for the new "connecting" state.
--
Michael
