Re: Fix memory leak in gist_page_items() of pageinspect - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Fix memory leak in gist_page_items() of pageinspect
Date
Msg-id aVy5zEAG8memlM_0@paquier.xyz
Whole thread Raw
In response to Re: Fix memory leak in gist_page_items() of pageinspect  (Chao Li <li.evan.chao@gmail.com>)
List pgsql-hackers
On Mon, Dec 22, 2025 at 10:41:44AM +0800, Chao Li wrote:
> On Dec 19, 2025, at 18:26, Bertrand Drouvot <bertranddrouvot.pg@gmail.com> wrote:
>> Thanks! Done that way in the attached.
>
> LGTM. As the immediately following statement is if (!IS_INDEX(rel)),
> adding a comment to relation_open() feels very necessary.

The fact that partitioned indexes are not allowed in these functions
is not a fact that stands out, and one would be indeed tempted to make
the switch.  The tests would complain on relation open, though.
Reworded the comment a bit and applied the result.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Xuneng Zhou
Date:
Subject: Re: Implement waiting for wal lsn replay: reloaded
Next
From: Andrey Borodin
Date:
Subject: Re: Making jsonb_agg() faster