Re: pgsql: Add data type oid8, 64-bit unsigned identifier - Mailing list pgsql-committers

From Michael Paquier
Subject Re: pgsql: Add data type oid8, 64-bit unsigned identifier
Date
Msg-id aV3PJvIpF8fmhfIL@paquier.xyz
Whole thread Raw
In response to Re: pgsql: Add data type oid8, 64-bit unsigned identifier  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
On Tue, Jan 06, 2026 at 10:03:01PM -0500, Tom Lane wrote:
> sifaka doesn't like this, evidently because it uses
> -DSTRESS_SORT_INT_MIN.

Yes, I have noticed that.  I was just going to push a workaround that
uses '>' and '<' comparators instead of the direct outputs..

> Personally I'd just drop those tests of btoid8cmp --- what are they
> going to catch that's not caught by other tests?

btoid8cmp() is not tested directly by other tests, which is why, like
for the xid8 case, I have just added direct calls because that's
cheaper.
--
Michael

Attachment

pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pgsql: Add data type oid8, 64-bit unsigned identifier
Next
From: Michael Paquier
Date:
Subject: pgsql: Improve portability of test with oid8 comparison function